-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a notebook containing example usage of the client #91
base: v0.x.x
Are you sure you want to change the base?
Add a notebook containing example usage of the client #91
Conversation
4f47243
to
811b106
Compare
811b106
to
63171d8
Compare
Looking at this I still think that this could be CLI tools, doesn't look to complicated. I think one tool per endpoint would be a simpler start. Also I think we should add some pre-defined convenient constants for the EIC codes which gives DeliveryArea objects. If you aim for merging this notebook:
|
Does the client also offer a way to retrieve a list of public trades and continue streaming all subsequent trades? |
Even if this would make the notebook fail? |
Ok noted. Should we still merge this or rather not? |
Signed-off-by: camille-bouvy-frequenz <[email protected]>
Signed-off-by: camille-bouvy-frequenz <[email protected]>
63171d8
to
e1aa078
Compare
Good point, not sure, could also be a single env file that sets variables read from environment. However,
Do you think it's useful? |
I recon part of your message is missing here?
Yea I'd say that for some clients it would be great to have. |
The problem I see with having examples and this notebook is to maintain both, former is not such a big problem but notebooks are not so nice to maintain. So I would only keep it if it has some benefits over the CLI tools, e.g. I think it can be good for documenting examples. But the current version is not really complete yet. |
True that's a good point. I won't merge this then. I started working on the CLI tools & am almost done. I'll create a new PR for it tonight or tomorrow. |
No description provided.